[FFmpeg-devel] [PATCH 2/2] fftools/resman: use inflate loop with increasing buffer size

[softworkz .]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of softworkz .
> Sent: Samstag, 31. Mai 2025 04:46
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Cc: Kieran Kunhya <kieran618 at googlemail.com>
> Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/resman: use inflate loop with
> increasing buffer size
> 
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Kieran
> > Kunhya via ffmpeg-devel
> > Sent: Samstag, 31. Mai 2025 04:39
> > To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> > Cc: Kieran Kunhya <kieran618 at googlemail.com>
> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/resman: use inflate loop
> with
> > increasing buffer size
> >
> > >
> > >         }
> > > +
> > > +        if (strm.avail_out == 0) {
> > > +            chunk *= 8;
> > >
> >
> >
> > *8 seems high
> 
> This would use 512kB when 64kB doesn't suffice. We're far away
> from 64kB, so it's just hypothetical.
> But granted - this happens usually just once during runtime for
> a resource and memory is more valuable than the inflate CPU cost,
> so I'm inclined to agree.
> 
> 2* or 4* ?
> 
> 
> Regards,
> sw
> _______________________________________________

Scratch that. Let's make it perfect instead. 

Please see V2.

Thanks
sw