[FFmpeg-devel] [FFmpeg-cvslog] avcodec/asvenc: Don't waste bits encoding non-visible part

[James Almer]

On 5/26/2025 10:22 AM, Andreas Rheinhardt wrote:
> James Almer:
>> On 5/26/2025 10:06 AM, Andreas Rheinhardt wrote:
>>> It is possible to hit this bug even before my patch with a commandline
>>> like this (tested with qemu):
>>> ffmpeg -filter_complex
>>> nullsrc=s=740x576:r=25,format=yuv420p,crop=w=720:x=2 -c:v asv2 -f null -
>>
>> Why does that generate unaligned strides? nullsrc uses
>> ff_get_video_buffer() to allocate a frame, which aligns strides with
>> av_cpu_max_align().
>>
> 
> In this example, it is the pointers, not the strides that are unaligned.

Right, the crop filter adds offsets to the data pointers. In that case 
I'm leaning towards encoders having to assume non aligned pointers are 
possible, and the asv2 encoder fixed to take that into account.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250526/271afde2/attachment.sig>