[FFmpeg-devel] [PATCH] aacdec_ac: fix signed overflow in ff_aac_ac_update_context()
Michael Niedermayer
michael at niedermayer.cc
Sat May 24 21:09:05 EEST 2025
On Fri, May 23, 2025 at 06:46:53AM +0900, Lynne wrote:
> The issue is that state->cur[] is 8-bits, but a+b+1 can overflow
> before being clipped to 0xF in the following line, causing an incorrect
> state to be saved for the next symbol.
>
> This solves numerous bitstream desyncs, particularly when coefficients
> with magnitude greater than 127 are sent.
> ---
> libavcodec/aac/aacdec_ac.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
LGTM
thx
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250524/0d070afa/attachment.sig>
More information about the ffmpeg-devel
mailing list