[FFmpeg-devel] [PATCH 1/2] avformat/rtsp: parse framerate in sdp

[Marvin Scholz]

On 23 May 2025, at 18:06, Michael Niedermayer wrote:

> On Fri, May 23, 2025 at 01:59:37AM +0200, Marvin Scholz wrote:
>> From: Erik Linge <erikli at axis.com>
>>
>> Co-authored-by: Marvin Scholz <epirat07 at gmail.com>
>> ---
>>  libavformat/rtsp.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
>> index 5ea471b40c..6807e1d6b5 100644
>> --- a/libavformat/rtsp.c
>> +++ b/libavformat/rtsp.c
>> @@ -618,6 +618,13 @@ static void sdp_parse_line(AVFormatContext *s, SDPParseState *s1,
>>                  s1->seen_fmtp = 1;
>>                  av_strlcpy(s1->delayed_fmtp, buf, sizeof(s1->delayed_fmtp));
>>              }
>> +        } else if (av_strstart(p, "framerate:", &p) && s->nb_streams > 0) {
>> +            // RFC 8866
>> +            double framerate;
>> +            if (av_sscanf(p, "%lf%c", &framerate, &(char){}) == 1) {
>> +                st = s->streams[s->nb_streams - 1];
>> +                st->avg_frame_rate = av_d2q(framerate, INT_MAX);
>> +            }
>
> mingw64:
>
> src/libavformat/rtsp.c: In function ‘sdp_parse_line’:
> src/libavformat/rtsp.c:624:58: error: empty scalar initializer
>   624 |             if (av_sscanf(p, "%lf%c", &framerate, &(char){}) == 1) {
>       |                                                          ^
> src/libavformat/rtsp.c:624:58: note: (near initialization for ‘(anonymous)’)
> make: *** [src/ffbuild/common.mak:81: libavformat/rtsp.o] Error 1
> make: *** Waiting for unfinished jobs....
>
>
> thx

Thanks for testing, I sent a new version that should fix this.

>
> [...]
>
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> If one takes all money from those who grow wealth and gives it to those who
> do not grow wealth, 10 years later, almost the same people who where wealthy
> will be wealthy again, the same people who where poor will be poor again.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".