[FFmpeg-devel] [PATCH 1/5] avformat/apvdec: Use ffio_read_size()

[Andreas Rheinhardt]

Mark Thompson:
> On 28/04/2025 10:39, Andreas Rheinhardt wrote:
>> Patches attached.
>>
>> - Andreas
>>
> 
>> [PATCH 1/5] avformat/apvdec: Use ffio_read_size()
> 
> LGTM.
> 
>> [PATCH 2/5] avformat/apvdec: Check before access
> 
> LGTM.
> 
>>     pkt->flags        = AV_PKT_FLAG_KEY;
> 
> Not sure where the funny alignment on this line came from (setting some other field there?) but suggest fixing it at the same time as this patch since you edit the previous line and it's not really worth its own patch.
> 
>> [PATCH 3/5] avformat/apvdec: Fix seeking
> 
> This makes more sense, thank you.  LGTM.
> 
>> [PATCH 4/5] avformat/apvdec: Remove inappropriate INIT_CLEANUP flag
> 
> Sure.
> 
>> [PATCH 5/5] avcodec/apv_entropy: Remove ff_apv_read_vlc()
> 
> See patch sent a few minutes ago - suggestions for nicer answer welcome.  (Copy/paste is not a nicer answer.)
> 

a) #include "libavcodec/apv_entropy.c" in the test program.
b) Move apv_read_vlc() into a header (apv_decode.h).
I'd prefer a).

- Andreas