[FFmpeg-devel] [PATCH v2] videotoolbox: Fix building with older SDKs

[Zhao Zhili]

> On Mar 26, 2025, at 16:53, Martin Storsjö <martin at martin.st> wrote:
> 
> The kVTVideoDecoderReferenceMissingErr constant was only added
> in the macOS 12 and iOS 15 SDKs. Use a hardcoded value instead
> of the named constant, to fix building with older SDKs
> after c6214b0d691566c7cb0f2ff5be08a24c3534e5bb.

LGTM. Thanks for the fix.

> ---
> libavcodec/videotoolbox.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
> index aaa6129576..a744657957 100644
> --- a/libavcodec/videotoolbox.c
> +++ b/libavcodec/videotoolbox.c
> @@ -728,7 +728,8 @@ static void videotoolbox_decoder_callback(void *opaque,
>     }
> 
>     if (!image_buffer) {
> -        if (status != kVTVideoDecoderReferenceMissingErr)
> +        // kVTVideoDecoderReferenceMissingErr, defined since the macOS 12 SDKs
> +        if (status != -17694)
>             vtctx->reconfig_needed = true;
> 
>         av_log(vtctx->logctx, status ? AV_LOG_WARNING : AV_LOG_DEBUG,
> -- 
> 2.39.5 (Apple Git-154)
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".