[FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: make InputFilterPriv and OutputFilterPriv private again

[James Almer]

On 6/1/2025 11:07 PM, softworkz . wrote:
> 
> 
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of softworkz .
>> Sent: Samstag, 31. Mai 2025 03:44
>> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
>> Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: make
>> InputFilterPriv and OutputFilterPriv private again
> 
> [..]
> 
>> 7 lines further down, there's another change needed:
>>
>>
>>          if (ofilter->output_name && ofilter->filter)
>>              av_dict_set(&output_map, ofilter->filter->name, ofilter-
>>> output_name, 0);
>>
>>
>> This is what broke the graph connections on the output side.
>>
>> Thanks
>> sw
>>
>> _______________________________________________
> 
> 
> Hello James,
> 
> I have seen you already pushed this.
> 
> What I would like to note is that you could have just asked me
> and I would have done it myself. This goes without saying.

I pushed the set because i authored it. No point asking someone else to 
do it. I did however forget to send a reply acknowledging your review 
and LGTM before pushing it.

> 
> I'm still saying it because I've already seen a satement
> of something like "had to clean up your mess" or similar.
> Though, nobody "has to". Just tell me and I'll do it, unless
> you're having fun doing it.
> 
> Not telling me and later saying "I had to..." - that's not
> valid. (just hypothetically, I'm not saying you did)
> 
> Please talk to me next time, I don't bite.
> 
> PS: you might be upset at the moment, but I've been 10
>      times more for sure

I'm not.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250601/9c5cc274/attachment.sig>