[FFmpeg-devel] [PATCH 01/11] fftools/graph/graphprint: Fix races when initializing graphprint

[softworkz .]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Andreas
> Rheinhardt
> Sent: Sonntag, 1. Juni 2025 05:27
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: [FFmpeg-devel] [PATCH 01/11] fftools/graph/graphprint: Fix races when
> initializing graphprint
> 
> Patches attached.
> 
> - Andreas


Hi Andreas,

thanks for the patches - most looking good from a glance.

I have a few questions:

- Why do you want to remove the ResourceManager AVClass?
  It wasn't unused. Now the prefix is gone for log entries in 
  decompress_gzip()
  Actually, all av_log() calls should include the resman_ctx
  Seems this has been forgotten (well..by me)
  
- For the registered_formatters initialization:
  I used to have initialization order issues when I had tried
  with static initialization. That's the reason for those functions
  Probably you've done it differently as it seems to work so far 

- In resman.c:64 - should the resman_ctx be static?


Thanks
sw