[FFmpeg-devel] [PATCH] fftools/ffplay: Add check for av_malloc_array()
Jiasheng Jiang
jiashengjiangcool at gmail.com
Mon Jul 14 21:47:02 EEST 2025
Add check for the return value of av_malloc_array() to avoid
potential NULL pointer dereference.
Fixes: 4acd08be6c ("ffplay: port to lavu/tx")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool at gmail.com>
---
fftools/ffplay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fftools/ffplay.c b/fftools/ffplay.c
index 2a572fc3aa..12c626c851 100644
--- a/fftools/ffplay.c
+++ b/fftools/ffplay.c
@@ -1156,7 +1156,7 @@ static void video_audio_display(VideoState *s)
err = av_tx_init(&s->rdft, &s->rdft_fn, AV_TX_FLOAT_RDFT,
0, 1 << rdft_bits, &rdft_scale, 0);
}
- if (err < 0 || !s->rdft_data) {
+ if (err < 0 || !s->real_data || !s->rdft_data) {
av_log(NULL, AV_LOG_ERROR, "Failed to allocate buffers for RDFT, switching to waves display\n");
s->show_mode = SHOW_MODE_WAVES;
} else {
--
2.25.1
More information about the ffmpeg-devel
mailing list