[FFmpeg-devel] [PATCH 1/2] avformat/tee: refactor option processing

Nicolas George george at nsup.org
Mon Jul 7 19:00:12 EEST 2025


Marvin Scholz (HE12025-07-07):
> I never said not to check for it…

You gave that argument in reply to the code becoming more verbose.

> How is making an APIs return value adhere to its documentation
> "hypothetical reasons"?

It works.

>			  It clearly states "The returned entry key
> or value must not be changed, or it will cause undefined behavior."
> so it would be quite logical to make its return const to make it
> harder for someone to shoot themselves in the foot using the API.

Do you really have nothing better to do than argue with something that
works and that will not be changed in the foreseeable future?

-- 
  Nicolas George


More information about the ffmpeg-devel mailing list