[FFmpeg-devel] [PATCH] avcodec/adpcm: squelch uninitialized variable warnings

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Mon Jul 7 13:41:34 EEST 2025


Peter Ross:
> Fixes CID1655273 and CID1655274.
> ---
>  libavcodec/adpcm.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c
> index 92ab248f3d..527384b86d 100644
> --- a/libavcodec/adpcm.c
> +++ b/libavcodec/adpcm.c
> @@ -877,6 +877,9 @@ static int adpcm_sanyo_expand3(ADPCMChannelStatus *c, int bits)
>          add = (11 * c->step) >> 1;
>          c->step = 3 * c->step;
>          break;
> +    default:
> +        av_assert0(0); /* never reach here when bits is 3-bit */
> +        return 0;
>      }
>  
>      if (sign)
> @@ -934,6 +937,9 @@ static int adpcm_sanyo_expand4(ADPCMChannelStatus *c, int bits)
>          add = (25 * c->step) >> 1;
>          c->step = 5 * c->step;
>          break;
> +    default:
> +        av_assert0(0); /* never reach here when bits is 4-bit */
> +        return 0;
>      }
>  
>      if (sign)
> 

Why not av_unreachable()?

- Andreas



More information about the ffmpeg-devel mailing list