[FFmpeg-devel] [PATCH v0] Implement promeg decoder.

Michael Niedermayer michael at niedermayer.cc
Fri Jan 17 19:08:23 EET 2025


Hi Kieran

On Fri, Jan 17, 2025 at 04:05:09PM +0000, Kieran Kunhya via ffmpeg-devel wrote:
> On Fri, Jan 17, 2025 at 2:48 PM James Almer <jamrial at gmail.com> wrote:
> >
> > On 1/17/2025 11:42 AM, Nicolas George wrote:
> > > James Almer (12025-01-17):
> > >> Don't assume he will not extend the implementation. Ask him instead what he
> > >> plans to do in the long term.
> > >> And this could also be marked as experimental, in which case if abandoned or
> > >> proven unstable for several real world cases, it can be removed or disabled.
> > >
> > > You were asking for proof that corporate-style mindset harms the
> > > project, you have one right here: “we do not want this new feature
> > > because it could mean bad PR” is one of the leitmotivs that have pushed
> > > the project towards stagnation since the GA has had influence.
> >
> > I don't see how the GA has anything to do with this when we're talking
> > about one person, but you're not wrong in that rejecting a feature for
> > being incomplete is not ideal.
> > The codebase is not lacking in partially implemented features and
> > protocols, and as long as it's stable, is not invasive, and gracefully
> > rejects unsupported scenarios, IMO it should be ok. But Kieran's
> > requests should be addressed. And like i said, marking it as
> > experimental is an option.
> 
> Just to add here what I wrote on IRC. FEC *by definition* is meant to
> be used on lossy and otherwise problematic networks.
> Therefore it cannot crash, infinite loop etc. Nor can it be "elegant".
> The reality is it has heuristics to deal with the real world like any
> loss tolerant protocol. This is in addition to the other issues this
> implementation has.

If there are issues in a patch, the best is to point the patch author
to these issues with sufficient detail so he can correct them.

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250117/8e9eca5d/attachment.sig>


More information about the ffmpeg-devel mailing list