[FFmpeg-devel] [PATCH 2/2] lavc/ac3dsp: fix R-V HAVE_RVV scope issue

[Rémi Denis-Courmont]

Le 13 janvier 2025 17:01:01 GMT+08:00, "mypopy at gmail.com" <mypopy at gmail.com> a écrit :
>On Sun, Jan 12, 2025 at 10:11 PM Rémi Denis-Courmont <remi at remlab.net> wrote:
>>
>>
>>
>> Le 8 janvier 2025 19:42:15 GMT+08:00, Jun Zhao <mypopy at gmail.com> a écrit :
>> >From: Jun Zhao <mypopydev at gmail.com>
>> >
>> >fix R-V HAVE_RVV scope issue
>> >
>> >Signed-off-by: Jun Zhao <barryjzhao at tencent.com>
>> >---
>> > libavcodec/riscv/ac3dsp_init.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> >diff --git a/libavcodec/riscv/ac3dsp_init.c b/libavcodec/riscv/ac3dsp_init.c
>> >index 24b3881854..f68a592839 100644
>> >--- a/libavcodec/riscv/ac3dsp_init.c
>> >+++ b/libavcodec/riscv/ac3dsp_init.c
>> >@@ -65,8 +65,8 @@ av_cold void ff_ac3dsp_init_riscv(AC3DSPContext *c)
>> >                 c->sum_square_butterfly_int32 =
>> >                     ff_sum_square_butterfly_int32_rvv;
>> > #  endif
>> >-# endif
>> >         }
>> >     }
>> >+# endif
>> > #endif
>> > }
>>
>> Probably correct.
>Yes, so I suspect that this problematic code path was not previously tested

Of course, nobody tests builds with broken old compilers. This issue is not visible otherwise unless forcefully disabling RVV.