[FFmpeg-devel] [PATCH v2] fate/vvc: Add vvc-frames-with-ltr.vvc

[Nuo Mi]

LGTM.
On Wed, Jan 8, 2025 at 7:51 PM Frank Plowman <post at frankplowman.com> wrote:

> This sample is rather difficult, containing a lot of subtle edge cases
>
Are we still encountering issues with the latest code?

> which revealed errors in the VVC decoder.  It covers 88.4% of lines in
> libavcodec/vvc and brings the line coverage of the entire VVC fate suite
> from 96.3% to 97.2%.
>
> Signed-off-by: Frank Plowman <post at frankplowman.com>
> ---
> Changes since v1:
> * Remove instantiation of empty $(SCALE_OPTS) in
>   fate-vvc-frames-with-ltr.
> * Move fate-vvc-frames-with-ltr to collection of VVC test cases which
>   require libswscale as it is a 10-bit sequence.
> ---
>  tests/fate/vvc.mak                 |  8 +++++---
>  tests/ref/fate/vvc-frames-with-ltr | 25 +++++++++++++++++++++++++
>  2 files changed, 30 insertions(+), 3 deletions(-)
>  create mode 100644 tests/ref/fate/vvc-frames-with-ltr
>
> diff --git a/tests/fate/vvc.mak b/tests/fate/vvc.mak
> index fb176b7745..76a4255e27 100644
> --- a/tests/fate/vvc.mak
> +++ b/tests/fate/vvc.mak
> @@ -43,11 +43,13 @@ $(VVC_TESTS_10BIT): SCALE_OPTS := -pix_fmt yuv420p10le
> -vf scale
>  $(VVC_TESTS_444_10BIT): SCALE_OPTS := -pix_fmt yuv444p10le -vf scale
>  fate-vvc-conformance-%: CMD = framecrc -c:v vvc -i
> $(TARGET_SAMPLES)/vvc-conformance/$(subst fate-vvc-conformance-,,$(@)).bit
> $(SCALE_OPTS)
>  fate-vvc-output-ref: CMD = framecrc -c:v vvc -i
> $(TARGET_SAMPLES)/vvc/Hierarchical.bit $(SCALE_OPTS)
> +fate-vvc-frames-with-ltr: CMD = framecrc -c:v vvc -i
> $(TARGET_SAMPLES)/vvc/vvc_frames_with_ltr.vvc
>
>  FATE_VVC-$(call FRAMECRC, VVC, VVC, VVC_PARSER) += $(VVC_TESTS_8BIT)
> fate-vvc-output-ref
> -FATE_VVC-$(call FRAMECRC, VVC, VVC, VVC_PARSER SCALE_FILTER) +=
>   \
> -                                                    $(VVC_TESTS_10BIT)
>  \
> -
> $(VVC_TESTS_444_10BIT) \
> +FATE_VVC-$(call FRAMECRC, VVC, VVC, VVC_PARSER SCALE_FILTER) +=
>     \
> +                                                    $(VVC_TESTS_10BIT)
>    \
> +
> $(VVC_TESTS_444_10BIT)   \
> +
> fate-vvc-frames-with-ltr \
>
>  FATE_SAMPLES_FFMPEG += $(FATE_VVC-yes)
>
> diff --git a/tests/ref/fate/vvc-frames-with-ltr
> b/tests/ref/fate/vvc-frames-with-ltr
> new file mode 100644
> index 0000000000..357af8e732
> --- /dev/null
> +++ b/tests/ref/fate/vvc-frames-with-ltr
> @@ -0,0 +1,25 @@
> +#tb 0: 1/25
> +#media_type 0: video
> +#codec_id 0: rawvideo
> +#dimensions 0: 800x872
> +#sar 0: 0/1
> +0,          0,          0,        1,  2092800, 0xce6d9094
> +0,          1,          1,        1,  2092800, 0x599f9867
> +0,          2,          2,        1,  2092800, 0x6d068c57
> +0,          3,          3,        1,  2092800, 0x90e4d43c
> +0,          4,          4,        1,  2092800, 0x0e2c5d62
> +0,          5,          5,        1,  2092800, 0x4d6c0288
> +0,          6,          6,        1,  2092800, 0x6334cd3f
> +0,          7,          7,        1,  2092800, 0xd76d4407
> +0,          8,          8,        1,  2092800, 0x9bbc1e0b
> +0,          9,          9,        1,  2092800, 0xad3851b1
> +0,         10,         10,        1,  2092800, 0x37876792
> +0,         11,         11,        1,  2092800, 0x1f55a6b6
> +0,         12,         12,        1,  2092800, 0x94b37de2
> +0,         13,         13,        1,  2092800, 0x35e81d80
> +0,         14,         14,        1,  2092800, 0xa6c0de46
> +0,         15,         15,        1,  2092800, 0xb1a64e7a
> +0,         16,         16,        1,  2092800, 0xc02796a7
> +0,         17,         17,        1,  2092800, 0x30ab91c4
> +0,         18,         18,        1,  2092800, 0xe480a19f
> +0,         19,         19,        1,  2092800, 0x2818666d
> --
> 2.46.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>