[FFmpeg-devel] [PATCH 1/3] avfilter/delogo: add parameter to switch on circular delogo

[Jörg Habenicht]

Hi

Am 06.02.25 um 18:12 schrieb Michael Niedermayer:
> Hi Jörg
>
> On Tue, Feb 04, 2025 at 08:53:58PM +0100, Jörg Habenicht via ffmpeg-devel wrote:
>> Add a parameter (boolean) r to switch the area from
>> rectangular (r=0) to circular(r=1) delogo.
>>
[...]

>> @@ -209,6 +209,7 @@ static const AVOption delogo_options[]= {
>>      { "y",    "set logo y position",       OFFSET(y_expr),    AV_OPT_TYPE_STRING, { .str = "-1" }, 0, 0, FLAGS },
>>      { "w",    "set logo width",            OFFSET(w_expr),    AV_OPT_TYPE_STRING, { .str = "-1" }, 0, 0, FLAGS },
>>      { "h",    "set logo height",           OFFSET(h_expr),    AV_OPT_TYPE_STRING, { .str = "-1" }, 0, 0, FLAGS },
>> +    { "r",    "logo is round/ellipse",     OFFSET(round),     AV_OPT_TYPE_BOOL,   { .i64 =  0 },   0, 1, FLAGS },
> maybe a superellipse would be interresting
> https://en.wikipedia.org/wiki/Superellipse
>
> This would allow intermediates between a rectangle, elipse and rhombus
> I imagine this could cover more cases of logos

hm, good idea.

How do I get the user Interface right? Extending the new 'r' option from bool to accept a float type?

r=2.0 would result in an ellipse or circle and r=1.0 would result in a rhombus?

>
> either way teh 3 patches should be merged
>
> thx
>
>
my pleasure


cu

Jörg