[FFmpeg-devel] [PATCH v2 2/3] avcodec/libx264: Set FFCodec.pix_fmts field

Zhao Zhili quinkblack at foxmail.com
Wed Feb 5 19:56:34 EET 2025


From: Zhao Zhili <zhilizhao at tencent.com>

We can fix deprecation warning by not set p.pix_fmts, and copy
FFCodec.pix_fmts to FFCodec.p.pix_fmts in av_codec_init_static().
However, that method requires non-const FFCodec. So I decided to
set pix_fmts and p.pix_fmts both for now.
---
 libavcodec/libx264.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
index 409f45fc7d..ef3c8eb98b 100644
--- a/libavcodec/libx264.c
+++ b/libavcodec/libx264.c
@@ -1633,6 +1633,7 @@ const FFCodec ff_libx264_encoder = {
     .flush            = X264_flush,
     .close            = X264_close,
     .defaults         = x264_defaults,
+    .pix_fmts         = pix_fmts_all,
     .p.pix_fmts       = pix_fmts_all,
     .color_ranges     = AVCOL_RANGE_MPEG | AVCOL_RANGE_JPEG,
     .caps_internal  = FF_CODEC_CAP_INIT_CLEANUP | FF_CODEC_CAP_AUTO_THREADS
@@ -1659,6 +1660,7 @@ const FFCodec ff_libx264rgb_encoder = {
     .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY |
                       AV_CODEC_CAP_OTHER_THREADS |
                       AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE,
+    .pix_fmts       = pix_fmts_8bit_rgb,
     .p.pix_fmts     = pix_fmts_8bit_rgb,
     .p.priv_class   = &rgbclass,
     .p.wrapper_name = "libx264",
@@ -1691,6 +1693,7 @@ const FFCodec ff_libx262_encoder = {
     .p.capabilities   = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY |
                         AV_CODEC_CAP_OTHER_THREADS |
                         AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE,
+    .pix_fmts         = pix_fmts_8bit,
     .p.pix_fmts       = pix_fmts_8bit,
     .color_ranges     = AVCOL_RANGE_MPEG,
     .p.priv_class     = &X262_class,
-- 
2.46.0



More information about the ffmpeg-devel mailing list