[FFmpeg-devel] [PATCH] avcodec/nvenc: add compile time check for outputRecoveryPointSEI for HEVC

[Timo Rothenpieler]

On 04/02/2025 15:58, Zhao Zhili wrote:
> 
>> On Feb 4, 2025, at 22:00, Martin Storsjö <martin at martin.st> wrote:
>>
>> On Tue, 4 Feb 2025, James Almer wrote:
>>
>>> No, they don't need to match afaik. The headers are meant to be ABI backwards compatible (hence all the reserved fields).
>>
>> Right, then there's probably less concern about updating them.
>>
>>> I was just wondering if the headers were provided by your distro or not (Given they are compile time deps and not runtime), and looking now at the package lists in some, i see they are, so disregard my question.
>>
>> In my case I actually don't use distro provided headers, I use a manually installed set, but I don't really touch it unless I need to.
> 
> How about put a copy of nv-codec-headers inside ffmpeg source tree?
> So it can always up to date and easy to handle the dependency (I encountered some trouble on Unix path vs Window path with ffnvcodec.pc in msys environment).
> What are the disadvantages of this method?

That's how it's been in the past, and I have no plans to go back to that.
It forces everyone to use bleeding edge drivers whenever we bump the 
headers, which in some distros is outright impossible.

Outsourcing the headers enabled us to build modern FFmpeg with support 
for old drivers, just sacrificing modern features.