[FFmpeg-devel] [PATCH v2 04/10] fftools/tf_internal: Use ac_default_item_name

[softworkz .]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Andreas Rheinhardt
> Sent: Mittwoch, 16. April 2025 12:51
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v2 04/10] fftools/tf_internal: Use
> ac_default_item_name
> 
> softworkz:
> > From: softworkz <softworkz at hotmail.com>
> >
> > Signed-off-by: softworkz <softworkz at hotmail.com>
> > ---
> >  fftools/textformat/tf_internal.h | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/fftools/textformat/tf_internal.h
> b/fftools/textformat/tf_internal.h
> > index 7b326328cb..e145bc83bb 100644
> > --- a/fftools/textformat/tf_internal.h
> > +++ b/fftools/textformat/tf_internal.h
> > @@ -29,13 +29,9 @@
> >  #include "avtextformat.h"
> >
> >  #define DEFINE_FORMATTER_CLASS(name)                \
> > -static const char *name##_get_name(void *ctx)       \
> > -{                                                   \
> > -    return #name ;                                  \
> > -}                                                   \
> >  static const AVClass name##_class = {               \
> >      .class_name = #name,                            \
> > -    .item_name  = name##_get_name,                  \
> > +    .item_name  = av_default_item_name,             \
> >      .option     = name##_options                    \
> >  }
> >
> 
> I really don't know why you want to do this yourself instead of just
> using my patch.
> 
> - Andreas

I don't understand. Your patch is making changes to the 
DEFINE_FORMATTER_CLASS macro in every single tf_* file.
But these are already consolidate and removed from those
files, so your patch patched something that is removed in 
the new patchset.

What am I missing?

Thanks,
sw