[FFmpeg-devel] [PATCH v10 3/8] tests: Add chained ogg/vorbis stream dump test.

[Romain Beauxis]

Le ven. 4 avr. 2025 à 16:00, Michael Niedermayer
<michael at niedermayer.cc> a écrit :
>
> On Fri, Apr 04, 2025 at 03:53:14PM -0500, Romain Beauxis wrote:
> > Le ven. 4 avr. 2025 à 15:44, Michael Niedermayer
> > <michael at niedermayer.cc> a écrit :
> > >
> > > Hi Romain
> > >
> > > On Wed, Apr 02, 2025 at 01:29:35PM -0500, Romain Beauxis wrote:
> > > > ---
> > > >  tests/Makefile                             |  1 +
> > > >  tests/fate/ogg-vorbis.mak                  | 11 +++++++++++
> > > >  tests/ref/fate/ogg-vorbis-chained-meta.txt | 17 +++++++++++++++++
> > > >  3 files changed, 29 insertions(+)
> > > >  create mode 100644 tests/fate/ogg-vorbis.mak
> > > >  create mode 100644 tests/ref/fate/ogg-vorbis-chained-meta.txt
> > >
> > > Applying: tests: Add chained ogg/vorbis stream dump test.
> > > .git/rebase-apply/patch:48: trailing whitespace.
> > > Stream ID: 0, frame PTS: 128, metadata:
> > > .git/rebase-apply/patch:50: trailing whitespace.
> > > Stream ID: 0, frame PTS: 704, metadata:
> > > .git/rebase-apply/patch:58: trailing whitespace.
> > > Stream ID: 0, frame PTS: 128, metadata:
> > > .git/rebase-apply/patch:60: trailing whitespace.
> > > Stream ID: 0, frame PTS: 704, metadata:
> > > warning: 4 lines add whitespace errors.
> > >
> > > do the tests pass without the trailing whitespace ?
> >
> > I don't think it would. The text file is a dump from the command output.
>
> It passes here without the trailing whitespace
>
> I suggest to remove them, because some editors remove trailing whitespace
> some people git setups do too. It could cause pain to people
> if in c/h files trailing whitespace is forbidden but here its
> used.
> Also as this is ffmpeg output, maybe the code outputting trailing
> whitespace should be fixed

This can all be done.

Watch for v11 in here!

> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Rewriting code that is poorly written but fully understood is good.
> Rewriting code that one doesnt understand is a sign that one is less smart
> than the original author, trying to rewrite it will not make it better.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".