[FFmpeg-devel] [RFC] [PATCH] avcodec/cbs_h266: Fix copy paste mistake

[Frank Plowman]

Hi Marvin,

Thanks for this patch and sorry for not getting around to it sooner.

Patch LGTM, yes it is a mistake I made when copy-pasting the logic for
the width -- sorry about that!

Thanks again,
Frank

On 31/08/2024 22:25, Marvin Scholz wrote:
> The us macro expect the range_max here, which seems should be
> MAX_UINT_BITS(hlen) here.
> 
> Fix CID1618757 Copy-paste error
> ---
> 
> This code is non-trivial to understand so I might be wrong
> about this, it would be great if someone actually familiar
> with this can have a look if my assesment is correct here.
> 
> Also if it isn't, a comment here might help to clarify things.
> 
>  libavcodec/cbs_h266_syntax_template.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c
> index a8f5af04d0..0704da1d40 100644
> --- a/libavcodec/cbs_h266_syntax_template.c
> +++ b/libavcodec/cbs_h266_syntax_template.c
> @@ -1208,7 +1208,7 @@ static int FUNC(sps)(CodedBitstreamContext *ctx, RWContext *rw,
>                             win_top_edge_ctus > current->sps_subpic_ctu_top_left_y[i]
>                                 ? win_top_edge_ctus - current->sps_subpic_ctu_top_left_y[i]
>                                 : 0,
> -                           MAX_UINT_BITS(wlen), 1, i);
> +                           MAX_UINT_BITS(hlen), 1, i);
>                      } else {
>                          infer(sps_subpic_height_minus1[i],
>                                tmp_height_val -