[FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: ensure that the inserted filters exist

[James Almer]

On 9/20/2024 10:30 AM, James Almer wrote:
> If not, report it as a bug. avfilter_graph_create_filter() will return ENOMEM if the
> passed filter argument is NULL, which is misleading.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>   fftools/ffmpeg_filter.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
> index 8b420e68ab..27d74341b5 100644
> --- a/fftools/ffmpeg_filter.c
> +++ b/fftools/ffmpeg_filter.c
> @@ -1444,11 +1444,15 @@ static int insert_filter(AVFilterContext **last_filter, int *pad_idx,
>                            const char *filter_name, const char *args)
>   {
>       AVFilterGraph *graph = (*last_filter)->graph;
> +    const AVFilter *filter = avfilter_get_by_name(filter_name)

Missing colon added locally...

>       AVFilterContext *ctx;
>       int ret;
>   
> +    if (!filter)
> +        return AVERROR_BUG;
> +
>       ret = avfilter_graph_create_filter(&ctx,
> -                                       avfilter_get_by_name(filter_name),
> +                                       filter,
>                                          filter_name, args, NULL, graph);
>       if (ret < 0)
>           return ret;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240920/d934b4af/attachment.sig>