[FFmpeg-devel] [PATCH] av_get_frame_filename2 parameter int -> int64_t

[Leo Izen]

On 9/16/24 2:22 PM, Filip Mašić wrote:
> my apologies for re-sending; i didn't spot that there was a header file. my previous email may be disregarded.
> 
> suggested fix for ticket 11194; see ticket for more info. i haven't been able to test this since i don't have any build tools installed, but decided to submit it since it seems to be a trivial change and easy to test
> 
> Signed-off-by: Filip Mašić <shoutplenty at gmail.com>
> ---
>   libavformat/avformat.h | 4 ++--
>   libavformat/utils.c    | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> index 4a3fb00529..76ffb008b4 100644
> --- a/libavformat/avformat.h
> +++ b/libavformat/avformat.h
> @@ -2911,10 +2911,10 @@ void av_dump_format(AVFormatContext *ic,
>    * @return 0 if OK, -1 on format error
>    */
>   int av_get_frame_filename2(char *buf, int buf_size,
> -                          const char *path, int number, int flags);
> +                          const char *path, int64_t number, int flags);
>   
>   int av_get_frame_filename(char *buf, int buf_size,
> -                          const char *path, int number);
> +                          const char *path, int64_t number);
>   

This is a breaking change, because you're changing the function 
signature (including the size of arguments) for a function exposed as
a public API. You'll need to figure out a solution that doesn't break
public interfaces.

- Leo Izen (Traneptora)