[FFmpeg-devel] [PATCH v4 2/4] libavformat/mxf: DNxUncompressed MXF related changes

[martin schitter]

On 11.09.24 08:14, Tomas Härdin wrote:
>> btw. there is an annoying flaw in the ffmpeg mxf parser:
>>
>> The very common 'fill' boxes, which are used in DNxUncompressed files
>> to
>> align 'pack' boxes on 265 byte boundaries, are not recognized by
>> ffmpegs
>> mxf parser and generate lots of
>> "Dark key 06.0e.2b.34.01.01.01.02.03.01.02.10.01.00.00.00" warnings.
 >
> Patch welcome 😉 

Done!

> But surely we already deal with KAG fill? Maybe the UL
> for it just has too large a matching length.. But looking at
> mxf_metadata_read_table[] and searching for "fill" it appears we don't?

The 'fill' key is present and used on the mxf encoder side, but it 
wasn't recognized by the decoder until now.

I hope, my patch looks acceptable to you.

Martin