[FFmpeg-devel] [PATCH] configure: enable warnings for shadowed variables

[Timo Rothenpieler]

On 08.09.2024 18:44, Zhao Zhili wrote:
> 
> 
>> On Sep 8, 2024, at 20:39, Timo Rothenpieler <timo at rothenpieler.org> wrote:
>>
>> On 08.09.2024 10:15, Andreas Rheinhardt wrote:
>>> Timo Rothenpieler:
>>>> These can easily lead to incredibly confusing errors, and should
>>>> practically never happen.
>>>> I'd have loved to make this a -Werror even, but sadly there is way too
>>>> many instances in the codebase right now that first needs to be weeded
>>>> out.
>>> IMO these instances would need to be weeded out before this is enabled
>>> even as a warning.
>>
>> There is almost 1000 of them without enabling much of any dependencies.
>> So I think that's next to impossible.
> 
> Then this patch will make it harder to see new warnings within thousands of warnings,
> isn’t it? It’s annoying to enable this warning before fix those code first.

Well, the reality is, that without printing all these warnings, nobody 
will ever fix them.
Unless someone sits down and spends potentially multiple days if not 
weeks of work to fix all the current ones.

If we print all the warnings instead, it can get fixed gradually.