[FFmpeg-devel] [PATCH] configure: enable warnings for shadowed variables

[Michael Niedermayer]

On Sat, Sep 07, 2024 at 08:52:41PM +0200, Timo Rothenpieler wrote:
> These can easily lead to incredibly confusing errors, and should
> practically never happen.
> I'd have loved to make this a -Werror even, but sadly there is way too
> many instances in the codebase right now that first needs to be weeded
> out.
> ---
>  configure | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure b/configure
> index a8e67d230c..547b67565d 100755
> --- a/configure
> +++ b/configure
> @@ -7406,6 +7406,7 @@ check_cflags -Wundef
>  check_cflags -Wmissing-prototypes
>  check_cflags -Wstrict-prototypes
>  check_cflags -Wempty-body
> +check_cflags -Wshadow

can you provide a list of warnings this produces ?
but in principle this seems a good idea

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Does the universe only have a finite lifespan? No, its going to go on
forever, its just that you wont like living in it. -- Hiranya Peiri
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240907/9624bef5/attachment.sig>