[FFmpeg-devel] [PATCH v3 0/2] avformat/mxfenc: Fix guess frame_rate

[Anton Khirnov]

Quoting Nicolas Gaullier (2024-09-02 17:49:04)
> >De : Anton Khirnov <anton at khirnov.net> 
> >Envoyé : lundi 2 septembre 2024 13:26
> >
> >Quoting Nicolas Gaullier (2024-09-02 11:52:15)
> >> Following yesterday posts by Anton/Tomas on version 1.
> >> 
> >> v3:
> >> - do not fall back to time_base (that was my v2)
> >> - do not remove "-r 25" in the fate test with streamcopy (see below)
> >> 
> >> What comes out:
> >> - mxfenc behaves the same as matroskaenc for example
> >> - avienc behaves differently: still sticked to time_base only
> >> 
> >> --
> >> 
> >> Another issue on this: "-r" as an output option with streamcopy is not 
> >> honored with mxf/matroska, but it is with avienc. This is because
> >> streamcopy_init() only overrides time_base, not *_frame_rate.
> >
> >Output -r should set avg_frame_rate, see line 958 in ffmpeg_mux_init.c.
> 
> Yes, but this is reset a few lines below.
> So, I will send a third patch in the same serie to address this; but maybe it can be discussed afterwards independently...

Right, didn't notice. Yes, that line should probably be just dropped.

> Except that issue,  do the patches for mxfenc look good to you ?

No objections from me.

-- 
Anton Khirnov