[FFmpeg-devel] [PATCH] Added support to enable VBV-End feature with x265 encode

[Yaswanth Sastry]

Hi Anton,

Thank you for your feedback. Could you please clarify which specific
development rules are being broken in this patch? I'm aiming to ensure that
the implementation is aligned with best practices and any guidelines I may
have missed.

In this patch, I’ve added support for the VBV-End feature, which is
conditional based on X265_BUILD >= 213, to ensure compatibility. The
changes are meant to enable smooth integration with FFmpeg, and the
duration value is being scaled to seconds for the VBV configuration.

If there are any specific issues with coding style, commit structure, or
any other aspect, I'd appreciate your guidance so I can address them
accordingly.

On Thu, Oct 17, 2024 at 2:46 PM Anton Khirnov <anton at khirnov.net> wrote:

> This breaks more development rules than there are lines changed, which
> is an impressive achievement.
>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>