[FFmpeg-devel] [PATCH v11 1/3] libavcodec/dnxucdec: DNxUncompressed decoder

[Michael Niedermayer]

Hi Martin

On Fri, Oct 11, 2024 at 04:12:54PM +0200, Martin Schitter wrote:
> On 11.10.24 10:57, Anton Khirnov wrote:
[...]
> But I immediately stumbled again over another nasty swscale related bug! :(
> 
> Just try it yourself:
> 
> First make a simple test with my last posted patch set:
> 
>   ./ffmpeg_g -i ./fate-suite/dnxuc/cb_rgb_float.mxf -c:v prores /tmp/out.mov
> 
> everything should simply work as expected
> 
> And now change line 348 of dnxucdec.c for float32 sub-format:
> 
> 
>          case MKTAG(' ','r','g','f'):
> -            ret = fmt_frame(avctx, frame, avpkt, AV_PIX_FMT_GBRPF32LE, 96,
> float2planes);
> +            ret = fmt_frame(avctx, frame, avpkt, AV_PIX_FMT_RGBF32LE, 96,
> pass_through);

If you look at format_entries in libswscale/utils.c
you will see that
    [AV_PIX_FMT_GBRPF32LE]   = { 1, 1 },
    [AV_PIX_FMT_GBRPF32BE]   = { 1, 1 },
Is supported, but AV_PIX_FMT_RGBF* is nowhere in the table of supported formats

Theres also sws_isSupportedInput() and sws_isSupportedOutput() that should show this

If you look at some of the recently posted patches by james, you can see
how new formats can be added to swscale

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241011/f7cd6cee/attachment.sig>