[FFmpeg-devel] [PATCH 1/2] configure: suggest installing nasm/yasm before using --disable-x86asm

[epirat07 at gmail.com]

On 9 Oct 2024, at 22:15, Alexander Strasser via ffmpeg-devel wrote:

> On 2024-10-03 04:04 +0200, Lynne via ffmpeg-devel wrote:
>> On 01/10/2024 15:24, vipyne wrote:
>>> ---
>>>   configure | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index c8fb49a7a4..d178ef59dc 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -6460,7 +6460,7 @@ EOF
>>>           for program in $x86asmexe nasm yasm; do
>>>               probe_x86asm $program && break
>>>           done
>>> -        disabled x86asm && die "nasm/yasm not found or too old. Use --disable-x86asm for a crippled build."
>>> +        disabled x86asm && die "nasm/yasm not found or too old. Please install/update nasm or yasm or use --disable-x86asm for a slower build."
>>>           X86ASMFLAGS="-f $objformat"
>>>           test -n "$extern_prefix"  && append X86ASMFLAGS "-DPREFIX"
>>>           case "$objformat" in
>>
>> Could you remove the yasm mention? Its been holding us back and we've
>> discussed dropping support for it enough in recent time to go ahead and do
>> it any day now.
>> Otherwise LGTM.
>
> No opinion on yasm, but IMHO the new wording proposal regarding the
> build is a little bit ambigous.
>
> What do you think about the following?
>
>     ...use --disable-x86asm for a build without hand-optimized assembly.
>
> I would hope it's clearer and more precise.
>

+1 from me, as „slower build“ could be understood as the process of building FFmpeg
will be slower.

>
> Best regards,
>   Alexander
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".