[FFmpeg-devel] [PATCH] configure: add spirv_compiler to avfilter_suggest as well

[Lynne]

On 07/10/2024 09:28, Hendrik Leppkes wrote:
> On Mon, Oct 7, 2024 at 9:15 AM Lynne via ffmpeg-devel
> <ffmpeg-devel at ffmpeg.org> wrote:
>>
>> If someone were to enable libglslang/libshaderc, and then disable
>> all Vulkan filters, they would have the same issue as the earlier
>> fix for libavcodec.
> 
> If you run such a setup, shouldn't the code that uses this then be excluded?

No, the files are always compiled if the user enabled support.
 > OBJS-$(CONFIG_LIBGLSLANG)                    += vulkan_glslang.o
 > OBJS-$(CONFIG_LIBSHADERC)                    += vulkan_shaderc.o

We do the same for qsv.
If we only supported a single SPIRV compiler, we could have instead 
added the file to every filter, but unfortunately, both libraries are 
used more or less equally by distributions and users.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xA2FEA5F03F034464.asc
Type: application/pgp-keys
Size: 624 bytes
Desc: OpenPGP public key
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241007/7165d6f0/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241007/7165d6f0/attachment.sig>