[FFmpeg-devel] [PATCH] lavc/h264dsp: fix R-V V weight_pixels pointer arithmetic

Rémi Denis-Courmont remi at remlab.net
Sun Nov 17 21:28:03 EET 2024


As of 459a1512f13ae1fdd404ff9281b02d225ac70a09,
the code is unrolled to process two rows per iteration.
The output cursor thus needs to be incremented by twice the
stride, which is taken care of with SH1ADD. However the original
ADD from the original implemetation was incorrectly left over.
---
 libavcodec/riscv/h264dsp_rvv.S | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libavcodec/riscv/h264dsp_rvv.S b/libavcodec/riscv/h264dsp_rvv.S
index 44f6202602..5423b716ca 100644
--- a/libavcodec/riscv/h264dsp_rvv.S
+++ b/libavcodec/riscv/h264dsp_rvv.S
@@ -52,7 +52,6 @@ func ff_h264_weight_pixels_simple_8_rvv, zve32x, b
         vse8.v      v8, (a0)
         vse8.v      v9, (t0)
         sh1add  a0, a1, a0
-        add     a0, a0, a1
         bnez    a2, 1b
 
         ret
-- 
2.45.2



More information about the ffmpeg-devel mailing list