[FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers (v2)

[Pavel Koshevoy]

On Fri, Nov 15, 2024 at 9:25 PM Anton Khirnov <anton at khirnov.net> wrote:

> Quoting Pavel Koshevoy (2024-11-15 20:32:21)
> > This avoids unpleasant surprises to av_frame_get_buffer callers
> > that explicitly specified 64-byte alignment and didn't get
> > AVFrame.data pointers that are 64-byte aligned.
> >
> > For example, see https://github.com/sekrit-twc/zimg/issues/212
> >
> > Although the zscale issue has already been resolved by other means
> > it would still be prudent to improve the behavior of av_frame_get_buffer
> > to fix any unknown and future instances of similar issues.
> > ---
> >  libavutil/frame.c | 4 +++-
> >  libavutil/frame.h | 7 ++++---
> >  2 files changed, 7 insertions(+), 4 deletions(-)
>
> I think this warrants a micro bump and an APIchanges entry, so external
> callers can reliably depend on this.
>
> Otherwise looks good.
>
> --
> Anton Khirnov
>


Thank you, I've submitted a v3 of the patch with doc/APIchanges entry added
and LIBAVUTIL_VERSION_MICRO bumped to 101.

BTW, I did not make any changes to get_audio_buffer which also accepts
an explicit alignment parameter.  I think it probably needs the same
changes.

Pavel.