[FFmpeg-devel] [FFmpeg-cvslog] lavf/demux: stop calling avcodec_close()

[Michael Niedermayer]

On Fri, Feb 09, 2024 at 03:19:58PM +0000, Anton Khirnov wrote:
> ffmpeg | branch: master | Anton Khirnov <anton at khirnov.net> | Thu Feb  1 08:57:24 2024 +0100| [ca18bb597223b3df5bbf8a1836d157ba58b62570] | committer: Anton Khirnov
> 
> lavf/demux: stop calling avcodec_close()
> 
> Replace it with recreating the codec context.
> 
> This is the last remaining blocker for deprecating avcodec_close().
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ca18bb597223b3df5bbf8a1836d157ba58b62570
> ---
> 
>  libavformat/demux.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 56 insertions(+), 5 deletions(-)

This breaks ffprobe "Closed Caption" output
before:
Stream #0:2[0x1e0]: Video: mpeg2video (Main), yuv420p(tv, progressive), 1920x1080 [SAR 1:1 DAR 16:9], Closed Captions, 29.97 fps, 59.94 tbr, 90k tbn

after:
Stream #0:2[0x1e0]: Video: mpeg2video (Main), yuv420p(tv, progressive), 1920x1080 [SAR 1:1 DAR 16:9], 29.97 fps, 59.94 tbr, 90k tbn

testcase:
./ffprobe ~/tickets/2147/sample.mpg 2>&1 | grep Stream

thx

should i open a ticket for this ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240327/e76f0116/attachment.sig>