[FFmpeg-devel] Patch which requires a new library

[Sergio Garcia Murillo]

El jue, 7 mar 2024, 16:30, Kieran Kunhya <kierank at obe.tv> escribió:

> On Thu, 7 Mar 2024 at 15:07, Sergio Garcia Murillo <
> sergio.garcia.murillo at gmail.com> wrote:
>
> >
> > Could anyone give me any pointers on what is the best way of doing this?
> >
>
> You should use a well known crypto library to implement this in FFmpeg (e.g
> libgcrypt, openssl
>

In fact, the sigv library allows to pass the crypto implementation you want
to use:

https://github.com/aws/SigV4-for-AWS-IoT-embedded-sdk/blob/dc530f7a21ec96db62afe73e21e3b7dfad0d648c/source/include/sigv4.h#L235

So the patch is already using whatever crypto library ffmpeg is configured
to use.

Anyway, not sure if i understood your feedback correctly, but my question
was about what is the best way of adding the sigv4 library as an optional
dependency in the configuration file and how to modify the patch so the
sigv4 specific code is only compiled if it is enabled by the configuration.

I have been looking at the contribution docs, but have found no info about
this.

Best regards
Sergio

>