[FFmpeg-devel] [PATCH v2] lavu/stereo3d: change the horizontal FOV field to a rational

[James Almer]

On 6/23/2024 11:14 AM, Lynne via ffmpeg-devel wrote:
> This avoids hardcoding any implementation-specific limitiations as
> part of the API, and allows for future expandability.
> 
> This also allows API users to more conveniently convert the
> values into floats without hardcoding specific conversion constants.
> 
> The API was committed 2 days ago, so changing this field now
> is within the realms of acceptable.

Five days, soon to be six.

[...]

> diff --git a/tests/ref/fate/matroska-spherical-mono b/tests/ref/fate/matroska-spherical-mono
> index b108596350..8b011e332f 100644
> --- a/tests/ref/fate/matroska-spherical-mono
> +++ b/tests/ref/fate/matroska-spherical-mono
> @@ -7,7 +7,7 @@ view=packed
>   primary_eye=none
>   baseline=0
>   horizontal_disparity_adjustment=0/1
> -horizontal_field_of_view=0
> +horizontal_field_of_view=0/0

Re-run fate. This and many other tests are not correct.

If Derek is also ok with this then LGTM.