[FFmpeg-devel] [PATCH] avformat: split off generic NAL function helpers into their own file

[Vittorio Giovara]

On Sun, Jun 16, 2024 at 7:09 PM James Almer <jamrial at gmail.com> wrote:

> diff --git a/libavformat/nal.h b/libavformat/nal.h
> new file mode 100644
> index 0000000000..ce49ea70b0
> --- /dev/null
> +++ b/libavformat/nal.h
> @@ -0,0 +1,66 @@
> +/*
> + * NAL helper functions for muxers
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> 02110-1301 USA
> + */
> +
> +#ifndef AVFORMAT_NAL_H
> +#define AVFORMAT_AVC_H
>

s/AVFORMAT_AVC_H/AVFORMAT_NAL_H/

Looks good! Do you think any of the parsing code could be reused in lavc
too?
-- 
Vittorio