[FFmpeg-devel] [PATCH 6/9] avcodec/libvpxenc: Cleanup on error

[Michael Niedermayer]

On Mon, Jun 17, 2024 at 10:10:38AM -0700, James Zern via ffmpeg-devel wrote:
> On Sun, Jun 16, 2024 at 4:09 PM Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> >
> > This or fifo needs to be freed on errors explicitly
> > I have not verified that its always safe to call vpx_free() this needs to be checked before applying this
> >
> 
> It should be safe to call into libvpx whether the encoder init
> succeeded or not; av_freep() is most of the rest of the code.

Thanks for checking


> 
> > Fixes: memleak
> > Fixes: 68937/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBVPX_VP8_fuzzer-4830831016214528
> >
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/libvpxenc.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> 
> lgtm.

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240619/eea53134/attachment.sig>