[FFmpeg-devel] [PATCH] avformat/dump: Print all possible Stereo3D info

[James Almer]

On 6/18/2024 12:31 PM, Derek Buitenhuis wrote:
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
> ---
> As requested by James.
> ---
>   libavformat/dump.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/libavformat/dump.c b/libavformat/dump.c
> index 059fb84522..8e8b9e1959 100644
> --- a/libavformat/dump.c
> +++ b/libavformat/dump.c
> @@ -260,6 +260,15 @@ static void dump_stereo3d(void *ctx, const AVPacketSideData *sd, int log_level)
>       stereo = (const AVStereo3D *)sd->data;
>   
>       av_log(ctx, log_level, "%s", av_stereo3d_type_name(stereo->type));
> +    av_log(ctx, log_level, ", view: %s", av_stereo3d_view_name(stereo->view));
> +    av_log(ctx, log_level, ", primary eye: %s", av_stereo3d_primary_eye_name(stereo->primary_eye));

nit: These three could be combined into a single av_log call.

> +    if (stereo->baseline)
> +        av_log(ctx, log_level, ", baseline: %"PRIu32"", stereo->baseline);
> +    if (stereo->horizontal_disparity_adjustment.num && stereo->horizontal_disparity_adjustment.den)
> +        av_log(ctx, log_level, ", horizontal_disparity_adjustment: %d/%d",
> +               stereo->horizontal_disparity_adjustment.num, stereo->horizontal_disparity_adjustment.den);
> +    if (stereo->horizontal_field_of_view)
> +        av_log(ctx, log_level, ", horizontal_field_of_view: %"PRIu32"", stereo->horizontal_field_of_view);

>   
>       if (stereo->flags & AV_STEREO3D_FLAG_INVERT)
>           av_log(ctx, log_level, " (inverted)");