[FFmpeg-devel] [PATCH 4/4 v2] avcodec/h264dec: add support for LCEVC enhancement

[Anton Khirnov]

Quoting James Almer (2024-07-26 14:10:46)
> On 7/26/2024 4:55 AM, Anton Khirnov wrote:
> > Quoting James Almer (2024-07-22 00:53:50)
> >> Signed-off-by: James Almer <jamrial at gmail.com>
> >> ---
> >>   configure                 |  2 +-
> >>   libavcodec/avcodec.h      |  5 +++++
> >>   libavcodec/h264_picture.c |  1 +
> >>   libavcodec/h264_slice.c   | 15 ++++++++++++++
> >>   libavcodec/h264dec.c      | 41 ++++++++++++++++++++++++++++++++++++---
> >>   libavcodec/h264dec.h      |  3 +++
> >>   6 files changed, 63 insertions(+), 4 deletions(-)
> > 
> > Does this need to be integrated into individual decoders? Can't the
> > generic path apply it based on the presence of AV_FRAME_DATA_LCEVC sdide
> > data and AV_CODEC_EXPORT_DATA_ENHANCEMENTS being set?
> 
> Individual decoders still need to be aware of lcevc metadata being 
> present to do things like allocating the output frame, because afaik i 
> can't call get_buffer2() from the main/user thread. So is it worth 
> moving things to the generic code when DR1 decoders will still need 
> extra considerations?

Can it not be handled in ff_get_buffer()? And even if not - there'd
still be a lot less code that needs to be duplicated across every
decoder supporting this.

-- 
Anton Khirnov