[FFmpeg-devel] [FFmpeg-cvslog] avcodec/vvc: Add aarch64 neon optimization for ALF

[Martin Storsjö]

On Mon, 22 Jul 2024, Nuo Mi wrote:

> On Mon, Jul 22, 2024 at 9:15 PM Martin Storsjö <martin at martin.st> wrote:
>       On Mon, 22 Jul 2024, Zhao Zhili wrote:
>
>       > ffmpeg | branch: master | Zhao Zhili <zhilizhao at tencent.com> |
>       Tue Jul 16 00:19:15 2024 +0800|
>       [2d4ef304c9e13f5e8abe37c20ddd0f17102c6393] | committer: Nuo Mi
>       >
>       > avcodec/vvc: Add aarch64 neon optimization for ALF
>       >
>       >>http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=2d4ef304c9e13f5e8
>       abe37c20ddd0f17102c6393
>       > ---
>       >
>       > libavcodec/aarch64/vvc/Makefile       |   5 +
>       > libavcodec/aarch64/vvc/alf.S          | 293
>       ++++++++++++++++++++++++++++++++++
>       > libavcodec/aarch64/vvc/alf_template.c | 157 ++++++++++++++++++
>       > libavcodec/aarch64/vvc/dsp_init.c     |  57 +++++++
>       > libavcodec/vvc/dsp.c                  |   4 +-
>       > libavcodec/vvc/dsp.h                  |   1 +
>       > 6 files changed, 516 insertions(+), 1 deletion(-)
>
>       I didn't review this patch yet.
>
>       I've been on vacation, and I was hoping to get to reviewing this
>       (and
>       other things) soon when I catch up.
>
>       The patch hasn't even been on the mailing list for one single
>       week! For
>       areas where earlier reviews have required multiple iterations to
>       get
>       patches right, I would hope that we could wait for an actual
>       review.
> 
> Hi Martin,
> Sorry for this.I will wait more time next time.
> Do you prefer to revert the patch temporarily?

No, it doesn't seem to be necesssary - the patch seems mostly fine in 
practice; I only have a couple of minor suggestions. I'll send a patch to 
fix those bits.

// Martin