[FFmpeg-devel] [PATCH 3/3] avcodec/videotoolboxenc: Fix variable type of AV_OPT_TYPE_BOOL

[James Almer]

On 7/16/2024 11:53 AM, Rémi Denis-Courmont wrote:
> Le tiistaina 16. heinäkuuta 2024, 17.46.53 EEST Zhao Zhili a écrit :
>> From: Zhao Zhili <zhilizhao at tencent.com>
>>
>> ---
>>   libavcodec/videotoolboxenc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
>> index 747681fd05..78ef474d7a 100644
>> --- a/libavcodec/videotoolboxenc.c
>> +++ b/libavcodec/videotoolboxenc.c
>> @@ -262,7 +262,7 @@ typedef struct VTEncContext {
>>       int realtime;
>>       int frames_before;
>>       int frames_after;
>> -    bool constant_bit_rate;
>> +    int constant_bit_rate;
>>
>>       int allow_sw;
>>       int require_sw;
> 
> Shouldn't it be fixed the opposite way, actually assigning to or evaluating as
> a boolean?

No, because -1 is allowed for AV_OPT_TYPE_BOOL, which is used as 
"undefined" in plenty of options.
And we don't use bool type anywhere as it's not really portable, or at 
least didn't use to. Dunno the current state ever since we moved to c11.