[FFmpeg-devel] [PATCH 14/22] avformat/tty: Check avio_size()
Michael Niedermayer
michael at niedermayer.cc
Fri Jul 12 02:34:08 EEST 2024
Fixes: CID1220824 Overflowed constant
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
libavformat/tty.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/libavformat/tty.c b/libavformat/tty.c
index 95b72005278..c3956ccf34e 100644
--- a/libavformat/tty.c
+++ b/libavformat/tty.c
@@ -123,13 +123,16 @@ static int read_header(AVFormatContext *avctx)
s->chars_per_frame = FFMAX(av_q2d(st->time_base)*s->chars_per_frame, 1);
if (avctx->pb->seekable & AVIO_SEEKABLE_NORMAL) {
- s->fsize = avio_size(avctx->pb);
- st->duration = (s->fsize + s->chars_per_frame - 1) / s->chars_per_frame;
+ int64_t fsize = avio_size(avctx->pb);
+ if (fsize > 0) {
+ s->fsize = fsize;
+ st->duration = (s->fsize + s->chars_per_frame - 1) / s->chars_per_frame;
- if (ff_sauce_read(avctx, &s->fsize, 0, 0) < 0)
- efi_read(avctx, s->fsize - 51);
+ if (ff_sauce_read(avctx, &s->fsize, 0, 0) < 0)
+ efi_read(avctx, s->fsize - 51);
- avio_seek(avctx->pb, 0, SEEK_SET);
+ avio_seek(avctx->pb, 0, SEEK_SET);
+ }
}
fail:
--
2.45.2
More information about the ffmpeg-devel
mailing list