[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: set keep_aspect to true for the crop filter

[James Almer]

On 7/10/2024 5:29 AM, Anton Khirnov wrote:
> Quoting James Almer (2024-07-09 21:06:26)
>> The input sample aspect ratio applies to the pre-cropping dimensions, so update it.
> 
> I don't understand this reasoning, why should cropping a video change
> pixel aspect ratio?

You're right, this patch is not ok. I noticed the display aspect ratio 
was preserved with this option, but this is not intended by the container.