[FFmpeg-devel] [PATCH] avformat/matroskaenc: Fix potential stack-buffer-overflow

[James Almer]

On 7/8/2024 2:09 PM, Andreas Rheinhardt wrote:
> Forgotten in f194f291d8082134cdce625b0ca3548067428ea9
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>   libavformat/matroskaenc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
> index 216cb48884..e1adc0eba6 100644
> --- a/libavformat/matroskaenc.c
> +++ b/libavformat/matroskaenc.c
> @@ -1758,7 +1758,7 @@ static int mkv_write_track_video(AVFormatContext *s, MatroskaMuxContext *mkv,
>       uint8_t color_space[4], projection_private[20];
>       const AVPacketSideData *sd;
>       EBML_WRITER(MAX_FIELD_ORDER_ELEMS + MAX_STEREO_MODE_ELEMS      +
> -                MAX_VIDEO_COLOR_ELEMS + MAX_VIDEO_PROJECTION_ELEMS + 8);
> +                MAX_VIDEO_COLOR_ELEMS + MAX_VIDEO_PROJECTION_ELEMS + 12);
>       int cropped_width = par->width, cropped_height = par->height;
>       int ret;
>   

LGTM, thanks.