[FFmpeg-devel] [PATCH v4 0/3] s/RUNTIME/POST_INIT_SETTABLE/
Andrew Sayers
ffmpeg-devel at pileofstuff.org
Sat Jul 6 21:03:21 EEST 2024
On Sat, Jul 06, 2024 at 06:49:51PM +0200, Michael Niedermayer wrote:
> On Sat, Jul 06, 2024 at 12:40:07PM +0200, Paul B Mahol wrote:
> [...]
>
> > its much more text to type too.
>
> shorter options:
>
> AV_OPT_FLAG_ALTERABLE_PARAM
>
> AV_OPT_FLAG_MUTABLE_PARAM
>
> (just in case consensus ends on a rename, i am not sure a rename is a good idea here)
I'm fine with someone doing s/POST_INIT_SETTABLE/MUTABLE/g on the patch before
committing it if they feel that's better, but ALTERABLE seems like a bad idea.
I guess you could argue a sufficiently inattentive reader might read
"POST_INIT_SETTABLE" to mean "*only* settable after init", even though
the documentation says otherwise. But such a reader might also read
"ALTERABLE" to somehow mean "data type can be altered" (like SQL's ALTER TABLE
statement), whereas "mutable" conventionally means "contents can be altered".
But this is just a nitpick - POST_INIT_SETTABLE is still fine by me.
More information about the ffmpeg-devel
mailing list