[FFmpeg-devel] [PATCH 15/15] avcodec/pixlet: Simplify pfx computation
Michael Niedermayer
michael at niedermayer.cc
Fri Jul 5 03:21:56 EEST 2024
Found by reviewing code related to CID1604365 Overflowed constant
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
libavcodec/pixlet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/pixlet.c b/libavcodec/pixlet.c
index 6b6e39f2757..e9c561d70d9 100644
--- a/libavcodec/pixlet.c
+++ b/libavcodec/pixlet.c
@@ -231,8 +231,8 @@ static int read_high_coeffs(AVCodecContext *avctx, const uint8_t *src, int16_t *
if (cnt1 >= length) {
cnt1 = get_bits(bc, nbits);
} else {
- pfx = 14 + ((((uint64_t)(value - 14)) >> 32) & (value - 14));
- if (pfx < 1 || pfx > 25)
+ pfx = FFMIN(value, 14);
+ if (pfx < 1)
return AVERROR_INVALIDDATA;
cnt1 *= (1 << pfx) - 1;
shbits = show_bits(bc, pfx);
--
2.45.2
More information about the ffmpeg-devel
mailing list