[FFmpeg-devel] [PATCH] avcodec/aaccoder_twoloop: remove unread max scaler

[Lynne]

On 14/06/2024 12:21, Yotam Ofek wrote:
> ---
>   libavcodec/aaccoder_twoloop.h | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/libavcodec/aaccoder_twoloop.h b/libavcodec/aaccoder_twoloop.h
> index c1dcdbb5ed..c56abc68a7 100644
> --- a/libavcodec/aaccoder_twoloop.h
> +++ b/libavcodec/aaccoder_twoloop.h
> @@ -101,7 +101,7 @@ static void search_for_quantizers_twoloop(AVCodecContext *avctx,
>        */
>       float sfoffs = av_clipf(log2f(120.0f / lambda) * 4.0f, -5, 10);
>   
> -    int fflag, minscaler, maxscaler, nminscaler;
> +    int fflag, minscaler, nminscaler;
>       int its  = 0;
>       int maxits = 30;
>       int allz = 0;
> @@ -572,12 +572,10 @@ static void search_for_quantizers_twoloop(AVCodecContext *avctx,
>           }
>   
>           minscaler = SCALE_MAX_POS;
> -        maxscaler = 0;
>           for (w = 0; w < sce->ics.num_windows; w += sce->ics.group_len[w]) {
>               for (g = 0;  g < sce->ics.num_swb; g++) {
>                   if (!sce->zeroes[w*16+g]) {
>                       minscaler = FFMIN(minscaler, sce->sf_idx[w*16+g]);
> -                    maxscaler = FFMAX(maxscaler, sce->sf_idx[w*16+g]);
>                   }
>               }
>           }

Thanks, pushed both patches.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xA2FEA5F03F034464.asc
Type: application/pgp-keys
Size: 624 bytes
Desc: OpenPGP public key
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240703/63de8f80/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240703/63de8f80/attachment.sig>