[FFmpeg-devel] [PATCH v2 4/4] vvcdec: reuse h26x/h2656_deblock_template.c

[Ronald S. Bultje]

Hi,

On Mon, Jan 8, 2024 at 10:05 PM Nuo Mi <nuomi2021 at gmail.com> wrote:

> On Tue, Jan 9, 2024 at 9:23 AM Ronald S. Bultje <rsbultje at gmail.com>
> wrote:
>
> > Hi,
> >
> > On Mon, Jan 8, 2024 at 8:03 PM Nuo Mi <nuomi2021 at gmail.com> wrote:
> >
> > > On Sat, Jan 6, 2024 at 6:52 PM Nuo Mi <nuomi2021 at gmail.com> wrote:
> > >
> > > > ---
> > > >  libavcodec/vvc/vvc_filter_template.c | 82
> +---------------------------
> > > >  1 file changed, 3 insertions(+), 79 deletions(-)
> > > >
> > > > diff --git a/libavcodec/vvc/vvc_filter_template.c
> > > > b/libavcodec/vvc/vvc_filter_template.c
> > > > index 9418980c33..671ed7de4e 100644
> > > > --- a/libavcodec/vvc/vvc_filter_template.c
> > > > +++ b/libavcodec/vvc/vvc_filter_template.c
> > > > @@ -461,6 +461,8 @@ static void
> FUNC(alf_recon_coeff_and_clip)(int16_t
> > > > *coeff, int16_t *clip,
> > > >  #define FQ2 pix[2  * xstride + 1 * ystride]
> > > >  #define FQ3 pix[3  * xstride + 1 * ystride]
> > > >
> > > > +#include "libavcodec/h26x/h2656_deblock_template.c"
> > > >
> > > Will merge this in two days if there are no objections to the file and
> > > directory names.
> > >
> >
> > Are there options to share the actual generated binary code? The C code
> > admittedly is not so important, but it would be great if there was some
> way
> > to ensure that optimizations written for HEVC in some instruction set,
> work
> > for VVC also - or vice versa.
> >
> Yes. After we merge this, we will send out the mc x86 asm code for review.
> It will share the same binary with HEVC.
> For SAO/Deblock, we will follow a similar approach, but it needs to be a
> little later than mc.
> For C code, we can share the binary as well, but it involves some interface
> changes, better to do it after all asm is ready.
>

OK, that sounds reasonable to me.

Ronald