[FFmpeg-devel] [PATCH v3] GSoC 2023: Add Audio Overlay Filter

[Thilo Borgmann]

Am 03.01.24 um 11:45 schrieb Gyan Doshi:
> 
> 
> On 2024-01-03 03:46 pm, Thilo Borgmann via ffmpeg-devel wrote:
>> Am 03.01.24 um 11:10 schrieb Gyan Doshi:
>>>
>>>
>>> On 2024-01-03 02:28 pm, Thilo Borgmann via ffmpeg-devel wrote:
>>>> Am 01.12.23 um 12:37 schrieb Paul B Mahol:
>>>>> On Fri, Dec 1, 2023 at 12:24 PM Gyan Doshi <ffmpeg at gyani.pro> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On 2023-09-25 11:35 pm, Paul B Mahol wrote:
>>>>>>> On 9/11/23, Harshit Karwal <karwalharshit at gmail.com> wrote:
>>>>>>>> 1. Replaced ring buffer ADT with AVAudioFifo from libavutil/audio_fifo.h
>>>>>>>> 2. Fixed potential freeing of uninitialised pointers in uninit
>>>>>>>> 3. Minor changes like removing unused headers
>>>>>>> Will apply with more fixes soon.
>>>>>>
>>>>>> Ping. Looks to be a useful filter.
>>>>>>
>>>>>
>>>>> After documentation general fixes are in master.
>>>>
>>>> Ping again.
>>>> What documentation fixes we were waiting for here?
>>>
>>> All the missing entries for (de)muxers, (de/en)coders ..etc.
>>
>> I don't really understand. Missing (de)muxer & (de/en)coders docs are blocking this filter? Do I miss a connection?
>> Is there some discussion regarding that on the list somewhere?
> 
> I was in the process of doc completion a few years ago when the pandemic hit, and I lost track of that. He made integrating
> this filter conditional on me resuming that effort. I intend to do so but can't commit to a firm timeline.

It would be nice if you would resume on that or post the status quo you already have which is still an enhancement.
It is not a reason for blocking a new filter coming in.


> Of course, if Paul isn't coming back, someone else will have to push anyway.

I pinged Paul about it, let's see if he's still interested.

In any way, I asked Harshit to add some tests to this filter to make it more complete.
Once that is done, and Paul has no more interest in it, we should proceed with this.

Thanks,
Thilo