[FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

James Almer jamrial at gmail.com
Sat Dec 14 19:40:50 EET 2024


On 12/14/2024 7:09 AM, Anton Khirnov wrote:
> Quoting Alexander Strasser via ffmpeg-devel (2024-12-01 21:13:56)
>> This is a fixed up version of the series I sent before.
>>
>> This worked for me on Ubuntu 20.04 but probably will break
>> with older zlib versions as Hendrik pointed out in the
>> previous thread. Either we must update zlib on affected
>> FATE clients or add more .alt files to them as well.
>>
>> We could also go the further the "no_file_checksums" as
>> was demonstrated by James' series.
>>
>> I still prefer this way because it's simpler and retains
>> the value of the tests.
> 
> This seems like a hack to me.
> 
> We should not be testing for bitexact output from code that is not under
> our control and does not guarantee bitexactness.

I sent a patch to remove the crc and size output from the ref files, but 
it did not really get much traction.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241214/eeefe5f6/attachment.sig>


More information about the ffmpeg-devel mailing list